Miscellaneous improvements to archetype reflection #8432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
enhancement
teh-cmc
commented
Dec 12, 2024
| /// Does this have a particular scope? | ||
| /// | ||
| /// e.g. `"blueprint"`. | ||
| pub scope: Option<&'static str>, |
There was a problem hiding this comment.
Really useful to filter stuff at runtime, without having to rely on shady str::contains shenanigans.
|
Web viewer failed to build. | Result | Commit | Link | Manifest | Note: This comment is updated whenever you push a commit. |
teh-cmc
commented
Dec 12, 2024
Comment on lines
+261
to
+262
| /// The name of the field (i.e. same as `ComponentDescriptor::archetype_field_name`). | ||
| pub name: &'static str, |
There was a problem hiding this comment.
Mandatory in order to be able to recreate complete ComponentDescriptors at runtime.
teh-cmc
force-pushed
the
cmc/improved_reflection
branch
from
7f4b73e to
b334cf5
Compare
Wumpf
approved these changes
Dec 12, 2024
teh-cmc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc improvements to the reflection that I had to implement while investigating forward-compat, migration scripts, etc.